Fix warnings with PHP 8

xp-framework · Mar 4, 2022 · 083de94 · 083de94
1 parent 6f6bb71
commit 083de94
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -5,6 +5,9 @@ Web tests change log
 
 ## 7.1.0 / 2022-03-04
 
+* Fixed *urlencode(): Passing null to parameter [...] of type string is
+  deprecated* warnings in PHP 8
+  (@thekid)
 * Added compatibility with XP 11, newer dependency versions - @thekid
 
 ## 7.0.0 / 2020-04-05

diff --git a/README.md b/README.md
@@ -25,7 +25,7 @@ class GitHubTestCase extends WebTestCase {
   public function home() {
     $this->beginAt('/');
     $this->assertStatus(200);
-    $this->assertTitleEquals('GitHub · Build software better, together.');
+    $this->assertTitleEquals('GitHub: Where the world builds software · GitHub');
   }
 }
 ```

diff --git a/src/main/php/unittest/web/Form.class.php b/src/main/php/unittest/web/Form.class.php
@@ -8,11 +8,9 @@
  * @see   xp://unittest.web.WebTestCase#getForm
  */
 class Form {
-  protected
-    $test   = null,
-    $node   = null,
-    $fields = null;
-
+  protected $test, $node;
+  protected $fields= null;
+
   /**
    * Constructor
    *
@@ -106,7 +104,7 @@ public function toString() {
   public function submit() {
     $params= '';
     foreach ($this->getFields() as $field) {
-      $params.= '&'.$field->getName().'='.urlencode($field->getValue());
+      $params.= '&'.$field->getName().'='.urlencode($field->getValue() ?? '');
     }
     $this->test->navigateTo($this->getAction(), substr($params, 1), $this->getMethod());
   }