Add support for running this server only on local interface#38
Open
sergey-protserov wants to merge 2 commits intoxphoenix:masterfrom
Open
Add support for running this server only on local interface#38sergey-protserov wants to merge 2 commits intoxphoenix:masterfrom
sergey-protserov wants to merge 2 commits intoxphoenix:masterfrom
Conversation
xphoenix
requested changes
Feb 24, 2019
Owner
xphoenix
left a comment
xphoenix
left a comment
There was a problem hiding this comment.
Давай, тогда уж, делать по-настоящему:
- Добавить опцию iface с именем интерфейса
- Прокинуть его, как и порт, в метод Start сервера
- Делать bind на интерфейс, если такого нет бросать исключение
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since our server has no authentication support, it may be insecure to run it on all interfaces in untrusted networks. So I decided to add support for running it only on local interface for the sake of security during testing.