Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow spherical star and other simplifications #359

Closed
thjsal opened this issue Jan 19, 2024 · 0 comments · Fixed by #476
Closed

Option to allow spherical star and other simplifications #359

thjsal opened this issue Jan 19, 2024 · 0 comments · Fixed by #476
Assignees
Labels
enhancement New feature or request hackweek2024 Issues to be fixed during the 2024 Hack Week

Comments

@thjsal
Copy link
Contributor

thjsal commented Jan 19, 2024

For testing and code comparison purposes, it can be handy to have the option to calculate the pulses from a spherical neutron star (instead of an oblate).

Here are instructions on how to make the star spherical currently in X-PSI:

Make this line:

return 1.0 + epsilon * (-0.788 + 1.030 * zeta) * mu * mu

to return 1.0.

Make this line:

return radiusDerivNormed / (radiusNormed * sqrt(1.0 - 2.0 * zeta / radiusNormed))

to return 0.0.

Make this line:


to return log10(g_0) + 2.0.

And then re-install X-PSI.

We can also think if turning time delays off could be a useful option. That can be turned off currently by setting _phase_lag=0.0 in the integrator files found in https://github.com/xpsi-group/xpsi/tree/main/xpsi/cellmesh and then re-installing X-PSI.

@thjsal thjsal added the enhancement New feature or request label Jan 19, 2024
@thjsal thjsal self-assigned this Feb 16, 2024
@thjsal thjsal added the hackweek2024 Issues to be fixed during the 2024 Hack Week label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hackweek2024 Issues to be fixed during the 2024 Hack Week
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant