Skip to content

Plotting Library #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Plotting Library #467

merged 9 commits into from
Dec 13, 2024

Conversation

sguillot
Copy link
Contributor

@sguillot sguillot commented Dec 5, 2024

New library collecting all plotting functions for the tutorial notebooks

New library collecting all plotting functions for the tutorial notebooks
@sguillot sguillot linked an issue Dec 5, 2024 that may be closed by this pull request
@sguillot sguillot changed the title [WIP] Plotting Library Plotting Library Dec 6, 2024
@DevarshiChoudhury DevarshiChoudhury marked this pull request as draft December 6, 2024 14:32
@sguillot sguillot marked this pull request as ready for review December 6, 2024 15:31
@sguillot
Copy link
Contributor Author

sguillot commented Dec 6, 2024

This PR can be reviewed (and merged), but not all tutorial notebooks have been adapted. They are still correct and running, they do not make use of the new plotting routines.

@sguillot
Copy link
Contributor Author

sguillot commented Dec 6, 2024

This also solves #444

@thjsal thjsal self-requested a review December 12, 2024 10:33
Some veneer function calls directed to the new plotting library.

Some text also updated.
Also: Comments in the tutorial updated, likelihood check values in examples updated, and number if sampling steps/iterations reduced in the tutorial to make it faster.
Copy link
Contributor

@thjsal thjsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be now good. I fixed a few things (see the commit messages above), but now the tutorials updated in this branch are working for me (and the example synthetic data matches to those created in the tutorial).

@thjsal thjsal merged commit d3458ac into main Dec 13, 2024
4 checks passed
@DevarshiChoudhury DevarshiChoudhury deleted the 242-common-plotting-functions-for-notebooks branch December 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move plotting functions of the notebooks into single plotting library
2 participants