Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog and version number updates #499

Merged
merged 14 commits into from
Dec 19, 2024
Merged

Changelog and version number updates #499

merged 14 commits into from
Dec 19, 2024

Conversation

thjsal
Copy link
Contributor

@thjsal thjsal commented Dec 16, 2024 •
edited
Loading

More text still to be added to the Changelog.

@thjsal thjsal linked an issue Dec 16, 2024 that may be closed by this pull request
Update changelog #478
Closed
@lmauviard lmauviard mentioned this pull request Dec 17, 2024
Closed
MHoogkamer
MHoogkamer requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@MHoogkamer MHoogkamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Updated the installation instructions for Helios and the example job script." should be "Helios and Snellius". Otherwise looks good to me!

@lmauviard lmauviard linked an issue Dec 17, 2024 that may be closed by this pull request
Chi2 error #502
Closed
@thjsal
Copy link
Contributor Author

thjsal commented Dec 17, 2024 •
edited
Loading

"Updated the installation instructions for Helios and the example job script." should be "Helios and Snellius". Otherwise looks good to me!

Sure. I have now fixed that.

@thjsal
Copy link
Contributor Author

thjsal commented Dec 17, 2024 •
edited
Loading

I have now rerun 2 tutorials to the update version number in them. Also fixed the SBI notebook to use the proper path to the example main module, and removed the sentence Make sure to run this first (python examples/examples_fast/Modules.main.py), to get all output files needed to execute this notebook. in the Post-processing tutorial, because that is not needed (all the files are already in GitHub).

@thjsal thjsal changed the title [WIP] Changelog and version number updates Changelog and version number updates Dec 19, 2024
@thjsal thjsal linked an issue Dec 19, 2024 that may be closed by this pull request
Proofread everything and re-run notebooks #450
Closed
@thjsal thjsal merged commit 6c7a025 into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MHoogkamer MHoogkamer MHoogkamer approved these changes

@drannawatts drannawatts drannawatts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chi2 error Update changelog Proofread everything and re-run notebooks
4 participants
@thjsal @drannawatts @MHoogkamer @lmauviard