Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import order issue moved to FAQ. #505

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

thjsal
Copy link
Contributor

@thjsal thjsal commented Jan 3, 2025

As discussed during the hack week, I added information about the import order issue of numpy and pymultinest to the FAQ pages so that the GitHub issue can be closed.

I also tried to reproduce the issue with newer X-PSI installations (both X-PSI v3.0.0 and v1.2.1 with newest dependencies), but I was not able to do that. Instead, the import order did not seem to affect the results at all (which I think makes more sense). I mentioned this also in the FAQ. I could not either reproduce the issue with the exact packages that were reported in the original issue, since my current laptop does not have an old enough version of gcc.

@thjsal thjsal requested a review from drannawatts January 3, 2025 09:51
@thjsal thjsal added the documentation Improvements or additions to documentation label Jan 3, 2025
@thjsal thjsal changed the title Import order issue moved in FAQ. Import order issue moved to FAQ. Jan 3, 2025
Copy link
Member

@drannawatts drannawatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@thjsal thjsal merged commit 2801387 into main Jan 7, 2025
4 checks passed
@thjsal thjsal deleted the import-order-affects-the-seed-fixed-results branch January 10, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The import order of pymultinest and numpy affects the seed-fixed results in certain conda environments
2 participants