Add {load,store}_unaligned for batch_bool on x86
#1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These work around GCC not being able to optimize the baseline implementations to SIMD operations, and compilers in general not being able to know that the vector representation is a bitmask of all 0 or all 1, thus integer 0 or -1. Also added some more robust tests for bool load/store that test for bitwise correctness (either 0 or 1).
|
Currently wresting with the 12905790283 flavors and non-orthogonality of x86 SIMD instructions... |
|
I like this change, thanks! |
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
Use the same approach as #1172
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
- Split some implementation that lived in sse4_1 while sse2 was a good home - Avoid auxiliary function
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
- Split some implementation that lived in sse4_1 while sse2 was a good home - Avoid auxiliary function
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
- Split some implementation that lived in sse4_1 while sse2 was a good home - Avoid auxiliary function
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
- Split some implementation that lived in sse4_1 while sse2 was a good home - Avoid auxiliary function
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
- Split some implementation that lived in sse4_1 while sse2 was a good home - Avoid auxiliary function
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
- Split some implementation that lived in sse4_1 while sse2 was a good home - Avoid auxiliary function
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 5, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 6, 2025
- Split some implementation that lived in sse4_1 while sse2 was a good home - Avoid auxiliary function
serge-sans-paille
added a commit
that referenced
this pull request
Oct 6, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 6, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 6, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 6, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 6, 2025
serge-sans-paille
added a commit
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These work around GCC not being able to optimize the baseline implementations to SIMD operations, and compilers in general not being able to know that the representation of
batch_boolis a bitmask of all 0 or all 1, thus integer 0 or -1.Also added some more robust tests for bool load/store that test for bitwise correctness (either 0 or 1).