XWIKI-21600: Various close button modals do not use icons #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated close buttons on two modals
* Updated close buttons on the export modal * Removed incorrect escaping from the location picker modal
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Updated close buttons on the export modal * Removed incorrect escaping from the location picker modal (cherry picked from commit 7758661)
surli
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Updated close buttons on the export modal * Removed incorrect escaping from the location picker modal (cherry picked from commit 7758661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21600
Changes
Description
Screenshots & Video
Before PR vvv
After PR - Font Awesome vvv
After PR - Silk vvv
Executed Tests
Only manual testing, see the screenshots above.
This only changes the content of a couple elements. I doubt this would fail any test.
Expected merging strategy