Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-15198: Skin logo doesn't change with the new Color Theme #3281

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jul 18, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-15198

Changes

Description

  • Added a translation to contain the warning for users.
  • Added this warning

Clarifications

  • I tried to have it not inline, but it did not work properly together with the definition list syntax.

Screenshots & Video

After the PR
image

Executed Tests

None except manual tests (as seen above). This is just a small update to some page content that isn't shown to default users.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.x
    • 16.4.x

* Added a translation to contain the warning for users.
* Added this warning

Note: I tried to have it not inline, but it did not work properly together with the definition list syntax.
@acotiuga
Copy link
Member

The Skin page displays multiple warning messages and we should keep consistency on their look.
I would expect something like this, where the warning is in a <div> instead of a <span>:
image

@michitux
Copy link
Contributor

I tried to have it not inline, but it did not work properly together with the definition list syntax.

Did you try using a group syntax to wrap the content of the definition list item?

@Sereza7
Copy link
Contributor Author

Sereza7 commented Jul 24, 2024

Did you try using a group syntax to wrap the content of the definition list item?

Yup, but trying to get around like this would just break the definition list. It would close the current DL, open the macro as standalone in its group and then reopen the DL soon after. It could be a bug with the syntax itself.

@Sereza7 Sereza7 marked this pull request as draft August 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants