fix memory leaks and other things in 29/btree.c #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxyzz
reviewed
Sep 6, 2023
29/btree.c
Outdated
| @@ -179,7 +190,11 @@ static char *toString(btree_t *btree) { | |||
| } | |||
|
|
|||
| static char *toStringHelper(node_t *h, int ht, char *indent) { | |||
| char *s = malloc(1024 * sizeof(char)); | |||
| // avoid weird characters and subsequent weird behavior when free by explicit initialization. | |||
| char *s = calloc(1024 * sizeof(char),1024); | |||
There was a problem hiding this comment.
Isn't this line should be calloc(sizeof(char), 1024)?. I'll review the rest code later, I need some time to refamiliarize the code and data structure...
There was a problem hiding this comment.
Yes, my mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the
valgrindto fix the memory leak errors in the code. Hope this can help the future readers understand the book.I also did the following:
char *s = calloc(1024 * sizeof(char),1024);to ensuresnot having weird characters which will influencestrcat(s, indent);.if (j > 0)to give one whole Btree graph.free_nodefunction to ensure no crash due to the memory leak with many iterations.