feat(integration-tests): Test compression with the CLP package.#1651
Closed
quinntaylormitchell wants to merge 62 commits intoy-scope:mainfrom
Closed
feat(integration-tests): Test compression with the CLP package.#1651quinntaylormitchell wants to merge 62 commits intoy-scope:mainfrom
quinntaylormitchell wants to merge 62 commits intoy-scope:mainfrom
Conversation
…ig file; address comments.
…er-level clp-config.yml
…E_CONFIGS other than clp-text and clp-json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…nning of fixture names.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…over between different modes during testing.
quinntaylormitchell
added a commit
to quinntaylormitchell/clp
that referenced
this pull request
Nov 23, 2025
3 tasks
This was referenced Nov 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the code that enumerates and facilitates compression test jobs that will be run on the CLP package.
Structure
Compression jobs are described with the
PackageCompressJobdata class. They are enumerated inclp_job_utils.py. Jobs relevant to the current test run are assembled inPackageJobListfor eachPackageConfigobject by a central job list creator. After the relevant package is spun up, the listed jobs for that package run are dispatched fromdispatch_test_jobsintest_clp_package.All listed compression jobs are run from
compress_with_clp_package. Success of compression is verified withrun_and_assert.NOTE: The code to check the correctness of this compression will be introduced in later PRs.
Command syntax
The dev running the integration test can select which jobs they'd like to run in a given test run by using the following command syntax from the
integration-testsdirectory:The central job list creator will add all of the relevant jobs depending on
<MODE_NAME>and'<JOB_NAME_OR_SUBSTRING>'.A simple spin-up and spin-down without any jobs can be run with the command
PR dependencies
This PR is built on top of the following PRs:
PackageConfigbased on the CLP package config. #1658Dependent PRs
This is a foundational infra PR, and so there are other PRs which depend on this one. They are listed below:
Checklist
breaking change.
Validation performed
Ran all permutations of possible user commands; all succeed.