refactor(deployment): Standardizes service names to use hyphens instead of underscores for RFC1123 compliance (resolves #1777).#1785
Draft
junhaoliao wants to merge 2 commits intoy-scope:mainfrom
Draft
Conversation
…ad of underscores for RFC1123 compliance (resolves y-scope#1777).
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…s for consistency with deployment standards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardizes service names to use hyphens instead of underscores for RFC1123 compliance
(resolves #1777).
Kubernetes requires RFC1123-compliant names that only allow lowercase alphanumeric characters
and hyphens (not underscores). This PR updates:
clp_py_utils/clp_config.pydocker-compose-all.yamldocker-compose.runtime.yamlclp_mode_utils.py(removed workaround function)Since Docker Compose uses the service name as the default hostname, redundant explicit
hostnamedeclarations were removed. The only exception isspider-compression-worker,which requires an explicit hostname of
compression-workerfor service discovery.Checklist
breaking change.
Validation performed
Manual inspection:
clp_config.pyuse hyphens instead of underscores.hostnamedeclarations removed (services use service name as default hostname)spider-compression-workerretains explicit hostname (compression-worker) as intended(excluding binary names like
/opt/clp/bin/spider_schedulerand Python module pathslike
job_orchestration.scheduler.query.query_schedulerwhich follow their respectivenaming conventions)
E2E test
Rebuilt the package and container image with
task package, then ran a full end-to-end test:Package startup
Output confirms hyphenated service names in setup logs:
All services running with correct names
Compression workflow
Service health verification
Package shutdown