Skip to content

fix(job-orchestration): Move garbage collector recovery file to temporary directory (fixes #1823). #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junhaoliao wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(job-orchestration): Move garbage collector recovery file to temporary directory (fixes #1823). #1834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e65a8b4
fix(job-orchestration): Move garbage collector recovery file to tempo…
junhaoliao Dec 26, 2025
958a655
fix(clp-package)!: Use tmpfs for temporary directory mounts in Docker…
junhaoliao Dec 26, 2025
ce02789
chore(helm): bump chart version to 0.1.2-dev.18
junhaoliao Dec 26, 2025
8e68200
bump chart version
junhaoliao Jan 7, 2026
8dd3902
Merge branch 'main' into docker-compose-tmp-tmpfs
junhaoliao Jan 14, 2026
2c0aa5f
revert tmpfs change
junhaoliao Jan 14, 2026
ba3cf5d
Merge branch 'main' into docker-compose-tmp-tmpfs
junhaoliao Jan 15, 2026
df52e4f
Merge branch 'main' into docker-compose-tmp-tmpfs
junhaoliao Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...onents/job-orchestration/job_orchestration/garbage_collector/archive_garbage_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ async def archive_garbage_collector(
validate_storage_type(archive_output_config, storage_engine)

sweep_interval_secs = clp_config.garbage_collector.sweep_interval.archive * MIN_TO_SECONDS
recovery_file = clp_config.logs_directory / f"{ARCHIVE_GARBAGE_COLLECTOR_NAME}.tmp"
recovery_file = clp_config.tmp_directory / f"{ARCHIVE_GARBAGE_COLLECTOR_NAME}.tmp"

logger.info(f"{ARCHIVE_GARBAGE_COLLECTOR_NAME} started.")
try:
Expand Down
2 changes: 1 addition & 1 deletion tools/deployment/package-helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: "v2"
name: "clp"
version: "0.1.4-dev.2"
version: "0.1.4-dev.3"
description: "A Helm chart for CLP's (Compressed Log Processor) package deployment"
type: "application"
appVersion: "0.9.1-dev"
Expand Down
2 changes: 1 addition & 1 deletion tools/deployment/package-helm/templates/garbage-collector-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ spec:
subPath: "clp-config.yaml"
readOnly: true
- name: "tmp"
mountPath: "/var/log"
mountPath: "/var/tmp"
{{- if eq .Values.clpConfig.archive_output.storage.type "fs" }}
- name: {{ include "clp.volumeName" (dict
"component_category" "shared-data"
Expand Down
1 change: 1 addition & 0 deletions tools/deployment/package/docker-compose-all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ services:
volumes:
- *volume_clp_config_readonly
- *volume_clp_logs
- *volume_clp_tmp
- "${CLP_ARCHIVE_OUTPUT_DIR_HOST:-empty}:/var/data/archives"
- "${CLP_AWS_CONFIG_DIR_HOST:-empty}:/opt/clp/.aws:ro"
- "${CLP_STREAM_OUTPUT_DIR_HOST:-empty}:/var/data/streams"
Expand Down
Loading