feat: Migrate from IRV1 to KV-IR serializer.#15
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
davidlion
left a comment
There was a problem hiding this comment.
Pretty small comments, nice work. Let's also make the title a bit more verbose since currently it isn't clear what we're dropping / migrating from.
|
I responded to ur comment in the original post |
Co-authored-by: davidlion <davidlion2@protonmail.com>
internal/irzstd/disk.go
Outdated
There was a problem hiding this comment.
Last fix: update this last part of the doc-string as discussed offline.
Description
This PR switches the serializer to KV-IR and drops support for the legacy IRV1 serializer.
KV-IR Serialization
This PR updates dependencies to use the new KV-IR serializer. The new serializer has a different API than the previous IRV1 serializer. The API change results in minor changes to the disk and memory writers.
JSON Parser Requirements
The KV-IR serializer requires logs to be parsed using Fluent Bit’s JSON parser. If logs are not JSON-parsed, the entire log will appear as a single string under the
logkey. The documentation has been updated to describe this requirement.Autogenerated Keys
Autogenerated keys are not supported in this PR. Support for autogenerated keys will be added in a future PR.
Checklist
breaking change.
Validation performed
JSON logs were sent to S3 using both the disk writer and the memory writer. The resulting files were opened in the log viewer, and the contents appeared correct.