Skip to content

feat: Migrate from IRV1 to KV-IR serializer.#15

Merged
davemarco merged 25 commits intoy-scope:mainfrom
davemarco:KVIR
Jan 29, 2026
Merged

feat: Migrate from IRV1 to KV-IR serializer.#15
davemarco merged 25 commits intoy-scope:mainfrom
davemarco:KVIR

Conversation

@davemarco
Copy link
Contributor

@davemarco davemarco commented Jan 19, 2026

Description

This PR switches the serializer to KV-IR and drops support for the legacy IRV1 serializer.

KV-IR Serialization

This PR updates dependencies to use the new KV-IR serializer. The new serializer has a different API than the previous IRV1 serializer. The API change results in minor changes to the disk and memory writers.

JSON Parser Requirements

The KV-IR serializer requires logs to be parsed using Fluent Bit’s JSON parser. If logs are not JSON-parsed, the entire log will appear as a single string under the log key. The documentation has been updated to describe this requirement.

Autogenerated Keys

Autogenerated keys are not supported in this PR. Support for autogenerated keys will be added in a future PR.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

JSON logs were sent to S3 using both the disk writer and the memory writer. The resulting files were opened in the log viewer, and the contents appeared correct.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@davemarco davemarco marked this pull request as ready for review January 23, 2026 19:48
@davemarco davemarco requested a review from a team as a code owner January 23, 2026 19:48
@davemarco davemarco requested a review from davidlion January 23, 2026 20:35
@davemarco davemarco changed the title Migrate to KV-IR serializer; remove support for plain-text output. feat: Migrate to KV-IR serializer. Jan 23, 2026
Copy link
Member

@davidlion davidlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty small comments, nice work. Let's also make the title a bit more verbose since currently it isn't clear what we're dropping / migrating from.

@davemarco davemarco changed the title feat: Migrate to KV-IR serializer. feat: Migrate from IRV1 to KV-IR serializer. Jan 28, 2026
@davemarco davemarco requested a review from davidlion January 28, 2026 16:40
@davemarco davemarco requested a review from davidlion January 29, 2026 03:36
@davemarco
Copy link
Contributor Author

I responded to ur comment in the original post

davemarco and others added 2 commits January 29, 2026 11:46
Co-authored-by: davidlion <davidlion2@protonmail.com>
Comment on lines 164 to 165
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last fix: update this last part of the doc-string as discussed offline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@davemarco davemarco requested a review from davidlion January 29, 2026 18:41
@davemarco davemarco merged commit da32e50 into y-scope:main Jan 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants