This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Emakiが将来どうなるかのスケッチを追加 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxfnc
commented
Feb 11, 2024
y047aka
reviewed
Feb 11, 2024
y047aka
reviewed
Feb 11, 2024
Co-authored-by: Yoshitaka Totsuka <y047aka@users.noreply.github.com>
Co-authored-by: Yoshitaka Totsuka <y047aka@users.noreply.github.com>
|
propsではなく、controlsにしたほうが良さそう |
pxfnc
commented
Feb 11, 2024
pxfnc
commented
Feb 11, 2024
y047aka
approved these changes
Feb 11, 2024
tsukimizake
approved these changes
Feb 11, 2024
|
📝 onChangeの部分は https://github.com/ymtszw/setem があればもっと楽になるが、exampleには載せず、将来いずれ書くドキュメントの付録にくっつける程度 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜやるのか
emakiのAPIが将来的にどうなるかの方針が今のリポジトリ上で参照できないため、ざっくりとした方針があったほうが実装の方針がブレづらくなって良い
やったこと