This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
[package] Follow new control api #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y047aka
commented
Mar 1, 2024
Comment on lines
-171
to
+173
| , onClickPlus = ProgressMsg Progress.CounterPlus | ||
| , onClickMinus = ProgressMsg Progress.CounterMinus | ||
| , onClickPlus = \ps -> { ps | value = Progress.clampValue (ps.value + 13) } | ||
| , onClickMinus = \ps -> { ps | value = Progress.clampValue (ps.value - 11) } |
There was a problem hiding this comment.
{ view : Html (props -> props) }にすると、外のmsgを使えないのがお悩みポイントではある。
制約と思えば今のところは許せるので、妥協案に変更しました。
y047aka
commented
Mar 1, 2024
| @@ -160,6 +160,7 @@ progressPlayground : Bool -> Progress.Model -> Html Msg | |||
| progressPlayground isDarkMode pm = | |||
| playground | |||
| { isDarkMode = isDarkMode | |||
| , toMsg = UpdateProgress | |||
There was a problem hiding this comment.
寄せてはみたものの、このPRではまだview関数のままなので、toMsg : (a -> a) -> msgをここで指定して辻褄合わせしています。フィールド毎に指定する必要がなくなったので、全体的な記述はすっきりしたかなと。
y047aka
commented
Mar 1, 2024
| @@ -92,6 +92,11 @@ update msg model = | |||
| ( model, Random.generate SetValue (Random.int -15 -10) ) | |||
|
|
|||
|
|
|||
| clampValue : Float -> Float | |||
| clampValue = | |||
| max 0 >> min 100 | |||
There was a problem hiding this comment.
Copilotがこれで良いんじゃない？って言ってたのを採用。
（min 100 (max 0 n)が微妙に分かりづらい印象を受けたので、ポイントフリースタイルにしてみた）
y047aka
commented
Mar 1, 2024
Comment on lines
+26
to
+27
| type alias Control props = | ||
| { view : Html (props -> props) } |
There was a problem hiding this comment.
新APIに寄せつつも、段階的に進めるべく、このPRではview関数の形を維持しています。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34 の実装を受けて、既存の
Controlモジュール側からも新APIに寄せてみます