Pig #16
Pig #16
Conversation
|
Code coverage is broken because of Cobertura's issues with Java 8. I will look into alternatives or get a clover license for Open Source. |
|
CLA is valid! |
|
Added clover and applied for a license. Coveralls doesn't support clover yet unfortunately but has an issue for this at trautonen/coveralls-maven-plugin#36 |
…except type specific checks
… dispatch without sacrificing code quality.
|
Adding some unrelated unit tests. Clover reports coverage at 96.3. It was around 60 before. The coveralls number of 99 was not accurate. |
|
Getting checks failed because of coverage drop. I added Jacoco instead of cobertura. It works because the actual coverage report of 96% caused the check to fail. I also bound checkstyle and jacoco to the verify and test lifecycles and temporarily added a line coverage requirement of 95% and branch of 90%. I'll add unit tests to get the check to pass. There is one more class that is not tested well - App. I also have an open source clover license from Atlassian. I find that using clover for local coverage visualization is better. Please reach out to me for the license if you need it. |
|
Coverage is now 99.5. I could have hit 100 but would require sacrificing brevity in TypeSystem.Operations. |
| @@ -38,11 +38,13 @@ | |||
| import static java.util.Collections.singletonList; | |||
|
|
|||
| public class Apiary implements Engine { | |||
| public static final String HIVE_JDBC = "hive-jdbc"; | |||
There was a problem hiding this comment.
Nice, thanks for pulling all these string constants out. Much cleaner.
|
This looks good to me, awesome stuff! |
|
I do want to test against a Hadoop cluster and perhaps write some documentation on what Pig/Hadoop jars and resources are needed to run it. I also want to test if registering UDFs etc in the script will work. I will hold off merging till that is cleared up. We may also need more settings that PigMain sets by default, notably tmpfilecompression etc. |
No description provided.