fix: merge optionally and enclosedBy

yajra · May 29, 2024 · b3081a4 · b3081a4
1 parent 3ece4e8
commit b3081a4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/src/ControlFileBuilder.php b/src/ControlFileBuilder.php
@@ -94,12 +94,8 @@ public function inserts(): string
                 $inserts .= "FIELDS TERMINATED BY '{$table->terminatedBy}' ";
             }
 
-            if ($table->optionally) {
-                $inserts .= 'OPTIONALLY ';
-            }
-
             if ($table->enclosedBy) {
-                $inserts .= "ENCLOSED BY '{$table->enclosedBy}'".PHP_EOL;
+                $inserts .= "OPTIONALLY ENCLOSED BY '{$table->enclosedBy}'".PHP_EOL;
             }
 
             if ($table->trailing) {

diff --git a/src/SQLLoader.php b/src/SQLLoader.php
@@ -72,11 +72,10 @@ public function into(
         string $table,
         array $columns,
         ?string $terminatedBy = ',',
-        bool $optionally = true,
         ?string $enclosedBy = '"',
         ?string $trailing = null
     ): static {
-        $this->tables[] = new TableDefinition($table, $columns, $terminatedBy, $optionally, $enclosedBy, $trailing);
+        $this->tables[] = new TableDefinition($table, $columns, $terminatedBy, $enclosedBy, $trailing);
 
         return $this;
     }

diff --git a/src/TableDefinition.php b/src/TableDefinition.php
@@ -10,7 +10,6 @@ public function __construct(
         public string $table,
         public array $columns,
         public ?string $terminatedBy = null,
-        public ?bool $optionally = null,
         public ?string $enclosedBy = null,
         public ?string $trailing = null
     ) {