Fix getPhotos #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates getPhotos to use Zillow's latest DOM structure and returns a collection rather than an array.
|
Haven't used Zillow for quiet some time so I may not be able to fully test the PR. Can you confirm that this is working and I would gladly merge this? Thanks! |
yajra
reviewed
Feb 5, 2020
| @@ -48,9 +48,9 @@ class ZillowClient | |||
| protected $results; | |||
|
|
|||
| /** | |||
| * @var array | |||
| * @var Illuminate\Support\Collection | |||
There was a problem hiding this comment.
I think we need to include illuminate\support on composer if we are going to use collection?
There was a problem hiding this comment.
I had added it in but when I was testing it resulted in some issues - I'll try to test more later as well as test getPhotos so you can merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates getPhotos to use Zillow's latest DOM structure and returns a collection rather than an array.