-
Notifications
You must be signed in to change notification settings - Fork 45
question about google oauth client_id #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soymuchacho
wants to merge
18
commits into
yakyak:master
Choose a base branch
from
wingc-china:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is Google Voice, and the delivery medium data for self state.
…buf explaining link http://hangups.readthedocs.org/en/stable/protobuf.html#conversationparticipantdata is missing field 4, the phone number, though.
… back. In this way the lib user can reply back to SMS.
…supported fields to parse boolean values directly. Also made the i18n_data field able to be parsed along with e164. The e164 is good enough to send SMS or make call, but the i18n is good for any phone number formatted display. Also updated the README.md file to reflect my changes.
… used to send SMS to such phone number. Accordingly, there is new field introduced to CLIENT_GET_ENTITY_BY_ID_RESPONSE. The logic should work like this: 1) Call getentitybyphonenumber and wait for response; 2) Parse the response to try read the entity from result.unknown.entities prior to the one from result.entities. If there are duplicated ones existing in both entities, use the one that unique in result.unknown.entieies. The logic behind should be the one from result.entities are Google account chat id but the differnt one from unknown should be the account's phone number. 3) Call createconversation with such chat_id, and then just sendchatmessage to the new conversation, with delivery medium as Google Voice.
… to parse objects coming from hangout
…t engine has problem to parse them when executing npm test.
…oad image. I highly suspect the uploadimage would work though from what I have experienced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"To login using an email/password combo, you need to login using OAuthand provide the access token to the API. Furthermore it uses a googlewhite listed OAuth CLIENT_ID and CLIENT_SECRET that shows up as "iOS Device" in your accounts page."