refactor(components): updated prop types and ref usage

yamada-ui · Sep 12, 2024 · ea49b54 · ea49b54
1 parent a6e9988
commit ea49b54
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/components/data-display/category.tsx b/components/data-display/category.tsx
@@ -210,7 +210,7 @@ const CategoryCarousel: FC<CategoryCarouselProps> = memo(
       <Box
         position="relative"
         w="full"
-        var={[
+        vars={[
           {
             name: "slide-gap",
             token: "spaces",

diff --git a/components/data-display/color-card.tsx b/components/data-display/color-card.tsx
@@ -2,6 +2,7 @@ import type {
   AspectRatioProps,
   BoxProps,
   GridProps,
+  Merge,
   MotionProps,
 } from "@yamada-ui/react"
 import {
@@ -26,7 +27,7 @@ export type ColorCardProps = AspectRatioProps & {
   size?: "md" | "lg"
   hex: string
   name?: string
-  linkProps?: Omit<BoxProps, "as"> & Omit<LinkProps, "as">
+  linkProps?: Merge<BoxProps, Omit<LinkProps, "as">>
   motionProps?: MotionProps
   gridProps?: GridProps
   boxProps?: BoxProps

diff --git a/components/forms/palette-menu.tsx b/components/forms/palette-menu.tsx
@@ -47,7 +47,7 @@ export const PaletteMenu = memo(
       })
       const { t } = useI18n()
       const { changePalette } = useApp()
-      const firstRef = useRef<HTMLDivElement>(null)
+      const firstRef = useRef<HTMLButtonElement>(null)
 
       const onSelect = useCallback(
         ({ colors, ...rest }: ColorPalette) => {
@@ -120,7 +120,7 @@ export const PaletteMenu = memo(
 PaletteMenu.displayName = "PaletteMenu"
 
 type PaletteButtonsProps = {
-  firstRef: RefObject<HTMLDivElement>
+  firstRef: RefObject<HTMLButtonElement>
   onSelect: (palette: ColorPalette) => void
 }
 
@@ -211,7 +211,7 @@ const PaletteButtons: FC<PaletteButtonsProps> = memo(
 PaletteButtons.displayName = "PaletteButtons"
 
 type CreatePaletteProps = {
-  firstRef: RefObject<HTMLDivElement>
+  firstRef: RefObject<HTMLButtonElement>
   onCloseRef: MutableRefObject<() => void>
 }