fixes #652 #653
Open
fixes #652 #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@3y3 @vitkarpov @iEgit нужно ревью ) |
chestozo
commented
Aug 29, 2017
src/ns.view.js
Outdated
| if (this.async && this.isLoading() && !this.isModelsValid()) { | ||
| this.asyncState = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
изначально хотел подложить сюда вычисление asyncState - https://github.com/yandex-ui/noscript/pull/653/files#diff-8398699a573a08340668f2925b626201L794 - но упало много тестов ... а тут не падает ничего )
There was a problem hiding this comment.
А новый тест-то на это есть? :)
There was a problem hiding this comment.
:) пока нет ) но старые не упали
но зато я понял уже, что не все кейсы потестил руками ...
пока ещё смотрю
There was a problem hiding this comment.
на такое наткнулся #654
chestozo
commented
Aug 30, 2017
| @@ -951,6 +951,8 @@ | |||
| // всегда собираем данные, в том числе закешированные модели для async-view | |||
| tree.models = this._getModelsForTree(); | |||
|
|
|||
| this._fixTreeStateByModels(tree); | |||
There was a problem hiding this comment.
Тут нужно бы ещё проверять this.isLoading().
|
Мы пока решили запатчить у себя на стороне вьюхи :/ |
|
Тестики? |
|
@3y3 will do ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.