Fix issue with event names #1
Open
+58
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p since kebab case is not working either
|
Note that the events are not able to be received due to this problem, rendering the event emission entirely no-op without this change. |
jhlee8804
added a commit
to jhlee8804/vue-multipane
that referenced
this pull request
Apr 1, 2019
…fix#19-yansern#15-yansern#14-yansern#7-yansern#17-yansern#1 * 'master' of https://github.com/vibou/vue-multipane: 0.96 fix issue with event names. Renamed: resize resizestart and resizestop since kebab case is not working either 0.96 0.96 0.96 Change version Change events name from camelcase to kebab-case # Conflicts: # demo/main.js # dist/vue-multipane.esm.js # dist/vue-multipane.js # dist/vue-multipane.min.js # src/multipane.js
|
Any plans on merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event names in camel case is not conform since HTML is case insensitive. Kebab case is prefered.