Improvements from code review

src/lib/y2storage/encryption_processes/tpm_fde_tools.rb

@@ -44,17 +44,17 @@ class TpmFdeTools < Base
       KEY_FILE_NAME = "/.fde-virtual.key".freeze
       private_constant :KEY_FILE_NAME
 
-      # Content of the third column of crypttab for all involved devices
-      #
-      # @return [String]
-      def self.key_file_name
-        KEY_FILE_NAME.dup
-      end
-
       # Class methods
       class << self
         # List of all block devices configured by fde-tools during system installation
         attr_accessor :devices
+
+        # Content of the third column of crypttab for all involved devices
+        #
+        # @return [String]
+        def key_file_name
+          KEY_FILE_NAME.dup
+        end
       end
 
       # Creates an encryption layer over the given block device

src/lib/y2storage/yast_feature.rb

@@ -19,11 +19,16 @@
 
 require "yast"
 require "y2storage/feature"
+require "yast2/equatable"
 
 module Y2Storage
   # Analogous to {StorageFeature}, but for requirements originated by Y2Storage and not
   # from libstorage-ng.
   class YastFeature < Feature
+    include Yast2::Equatable
+
+    eql_attr :id
+
     # Constructor
     def initialize(id, mandatory_pkgs, optional_pkgs)
       pkgs = mandatory_pkgs.map { |pkg| Package.new(pkg, optional: false) }
@@ -50,12 +55,5 @@ def self.all
     def self.drop_cache
       all.each(&:drop_cache)
     end
-
-    # @return [Boolean]
-    def ==(other)
-      other.class == self.class && other.id == id
-    end
-
-    alias_method :eql?, :==
   end
 end