Fix a bug when formatting a full disk as Btrfs with snapshots #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
force-pushed
the
fix-agama-btrfs-disk
branch
from
ace78c6
to
f90b6d5
Compare
ancorgs
force-pushed
the
fix-agama-btrfs-disk
branch
from
f90b6d5
to
60a876a
Compare
|
✔️ Internal Jenkins job #1158 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This bug at Agama was reported agama-project/agama#1339
Turns out the root of the error was an uncaught exception at the GuidedProposal caused because YaST was trying to adjust the sizes of the root device to fulfill the Btrfs-related settings... but such a device was a disk instead of an LV or partition.
Solution
Added the same guard we have in other parts of
DevicesPlanner(eg.adjust_sizes).Testing