Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the newer exfatprogs instead of exfat-utils [SLE-15-SP6] #1389

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented Sep 19, 2024

Target Branch

This is for SLE-15-SP6.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1187854

Trello

https://trello.com/c/N7gz5WP0

Problem

When determining what additional software packages are needed for a storage operation, e.g. in the expert partitioner, we still requested the old exfat-utils instead of the newer exfatprogs.

This can be relevant if the user wants to format e.g. a USB stick with the ExFAT filesystem, and the support package for that filesystem is not yet installed.

Fix

Add exfatprogs to the list of needed packages for the storage operations, not exfat-utils.

What about libstorage?

libstorage-ng has been using the binary from exfatprogs for quite a while already. But the user had to make sure manually that this package was installed.

Related PRs

@coveralls
Copy link

Coverage Status

coverage: 97.762%. remained the same
when pulling e31919b on huha-exfatprogs-sp6
into 3e86922 on SLE-15-SP6.

Copy link
Member

@kobliha kobliha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #1214 this has been already adapted in libstorage-ng, so AFAIS, LGTM

@shundhammer shundhammer merged commit 3926274 into SLE-15-SP6 Sep 19, 2024
12 checks passed
@shundhammer shundhammer deleted the huha-exfatprogs-sp6 branch September 19, 2024 16:23
@yast-bot
Copy link

✔️ Internal Jenkins job #9 successfully finished
✔️ Created IBS submit request #345604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants