Update: Column config reordering, sorting ability #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds metadata to columns indicating whether or not they support sorting, (e.g. false for fili dimensions) - ability to add/remove sort from column config - update table with column metadata for sorting
kevinhinterlong
force-pushed
the
column-config-reorder
branch
from
fd20340 to
8ed01cc
Compare
jkusa
reviewed
Mar 12, 2021
jkusa
reviewed
Mar 13, 2021
This was referenced Mar 15, 2021
added 2 commits
March 15, 2021 14:47
jkusa
reviewed
Mar 16, 2021
|
demo-reordering-sorting.mp4 |
jkusa
reviewed
Mar 17, 2021
packages/reports/app/styles/navi-reports/components/navi-column-config/base.scss
Outdated
Show resolved
Hide resolved
jkusa
approved these changes
Mar 17, 2021
…n-config/base.scss Co-authored-by: Jon Kilroy <jkilroy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #996
Resolves #985
Description
Screenshots
column.reordering.mp4
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.