Open
Conversation
yayyz
requested changes
Aug 13, 2025
day3/prac2/docker-compose.yml
Outdated
| environment: | ||
| - NGINX_HOST=localhost | ||
| volumes: | ||
| - ./html:C:\Users\fbdpc\docker-sandbox\day3\prac2\html |
Owner
There was a problem hiding this comment.
로컬 경로를 마운트 하면 다른 OS환경의 사용자들이 이 docker-compose 파일을 사용 못합니다!
볼륨을 지정해서 사용하는 걸로 수정해주세요!
day3/prac2/docker-compose.yml
Outdated
| name: myproject | ||
| services: | ||
| web: | ||
| image: nginx:latest |
Owner
There was a problem hiding this comment.
nginx가 아닌 Python flask app 제출이 요구사항입니다.
README.md 참고해주세요
yayyz
requested changes
Aug 13, 2025
| - ./app:/app | ||
| networks: | ||
| - app_net | ||
| depends_on: |
Owner
There was a problem hiding this comment.
depends_on 은 단순히 실행 순서만 보장하고, redis의 상태에 기반해서 실행하지는 않습니다!
몇가지 항목들이 더 추가되어야 할 것 같아요!
condition 과 같은 항목 참고 부탁드립니다 :)
Author
There was a problem hiding this comment.
쉽지않네요, ㅎㅎ 다시 수정했습니다. 또이상있으면 오후에 고치겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.