Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve profiling code logic #1728

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

fabclmnt
Copy link
Collaborator

  • Remove unused methods
  • Improve logic to ease code maintenance
  • Improve code performance (optimized with threads)
  • Fix Spark code to harness its native distributed capabilities

@fabclmnt fabclmnt force-pushed the fix/refactor_summarizer_logic branch from 7e8dbe5 to f9733ad Compare March 12, 2025 22:36
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 35 lines in your changes missing coverage. Please review.

Project coverage is 90.03%. Comparing base (9195531) to head (5d5ae1b).
Report is 46 commits behind head on develop.

Files with missing lines Patch % Lines
src/ydata_profiling/model/summary.py 57.14% 9 Missing ⚠️
src/ydata_profiling/model/missing.py 77.77% 8 Missing ⚠️
src/ydata_profiling/model/dataframe.py 66.66% 5 Missing ⚠️
src/ydata_profiling/model/correlations.py 84.61% 4 Missing ⚠️
src/ydata_profiling/model/summarizer.py 80.00% 4 Missing ⚠️
src/ydata_profiling/model/describe.py 72.72% 3 Missing ⚠️
src/ydata_profiling/profile_report.py 80.00% 1 Missing ⚠️
tests/issues/test_issue537.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1728      +/-   ##
===========================================
- Coverage    90.25%   90.03%   -0.23%     
===========================================
  Files          198      201       +3     
  Lines         6477     6621     +144     
===========================================
+ Hits          5846     5961     +115     
- Misses         631      660      +29     
Flag Coverage Δ
py3.12-ubuntu-22.04-pandas 90.03% <82.14%> (?)
py3.8-ubuntu-22.04-pandas ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants