Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #9461 with altering CDC streams #11077

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

FloatingCrowbar
Copy link
Collaborator

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 18:42:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for db7f388 has started.
2024-10-29 18:42:12 UTC Artifacts will be uploaded here
2024-10-29 18:45:10 UTC ya make is running...
🟢 2024-10-29 19:29:46 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15051 13559 0 0 1394 98

🟢 2024-10-29 19:31:02 UTC Build successful.
🟢 2024-10-29 19:31:20 UTC ydbd size 2.8 GiB changed* by +14.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 08f5064 merge: db7f388 diff diff %
ydbd size 3 038 244 440 Bytes 3 038 259 136 Bytes +14.4 KiB +0.000%
ydbd stripped size 481 263 544 Bytes 481 265 144 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 18:42:05 UTC Pre-commit check linux-x86_64-release-asan for db7f388 has started.
2024-10-29 18:42:16 UTC Artifacts will be uploaded here
2024-10-29 18:45:13 UTC ya make is running...
🟡 2024-10-29 19:52:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9175 9091 0 45 5 34

🟢 2024-10-29 19:53:35 UTC Build successful.
🟢 2024-10-29 19:54:07 UTC ydbd size 5.7 GiB changed* by +48.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5f37943 merge: db7f388 diff diff %
ydbd size 6 147 831 376 Bytes 6 147 881 264 Bytes +48.7 KiB +0.001%
ydbd stripped size 1 534 206 128 Bytes 1 534 216 112 Bytes +9.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

)");
RunQuery(query, session, false);
auto desc = pq.DescribeTopic("/Root/TmpTable/feed").ExtractValueSync();
UNIT_ASSERT_VALUES_EQUAL(desc.GetTopicDescription().GetPartitioningSettings().GetMinActivePartitions(), 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не понятно зачем это сравнивать.
может cdc создать с поддержкой автопартиционирования и проверить, что меняются min и max, и другие параметры топика?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants