Skip to content

fix of crash #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix of crash #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cbde4e
fix of crash
IOSDEVOPS2201 Apr 3, 2024
e87854d
fix of crash setNeedsDisplay
IOSDEVOPS2201 Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Source/RSCodeReaderViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,11 @@ open class RSCodeReaderViewController: UIViewController, AVCaptureMetadataOutput
if let ticker = self.ticker {
ticker.invalidate()
}
self.cornersLayer.cornersArray = []
DispatchQueue.main.async { [weak self] in
guard let self else { return }
self.cornersLayer.cornersArray = []
self.cornersLayer.setNeedsDisplay()
}
}

@objc func onTap(_ gesture: UITapGestureRecognizer) {
Expand Down Expand Up @@ -408,7 +412,11 @@ open class RSCodeReaderViewController: UIViewController, AVCaptureMetadataOutput
}
}

self.cornersLayer.cornersArray = cornersArray
DispatchQueue.main.async { [weak self] in
guard let self else { return }
self.cornersLayer.cornersArray = cornersArray
self.cornersLayer.setNeedsDisplay()
}

if barcodeObjects.count > 0 {
if let barcodesHandler = self.barcodesHandler {
Expand Down
8 changes: 1 addition & 7 deletions Source/RSCornersLayer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,7 @@ open class RSCornersLayer: CALayer {
@objc open var strokeColor = UIColor.green.cgColor
@objc open var strokeWidth: CGFloat = 2
@objc open var drawingCornersArray: Array<Array<CGPoint>> = []
@objc open var cornersArray: Array<[Any]> = [] {
willSet {
DispatchQueue.main.async(execute: {
self.setNeedsDisplay()
})
}
}
@objc open var cornersArray: Array<[Any]> = []

override open func draw(in ctx: CGContext) {
guard let cornerPointsArray = cornersArray as? [[CGPoint]] else { return }
Expand Down