feat: Add yETH to the header popover #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
commented
Aug 4, 2023
| @@ -68,7 +68,7 @@ function LogoPopover(): ReactElement { | |||
| leaveTo={'opacity-0 translate-y-1'}> | |||
| <Popover.Panel className={'absolute left-1/2 z-10 mt-6 w-80 -translate-x-1/2 px-4 pt-4 sm:px-0 md:w-96'}> | |||
| <div className={'overflow-hidden border border-neutral-200 shadow-lg'}> | |||
| <div className={'relative grid grid-cols-2 bg-neutral-0 md:grid-cols-4'}> | |||
| <div className={'relative grid grid-cols-2 bg-neutral-0 md:grid-cols-3'}> | |||
There was a problem hiding this comment.
Reduce to 3 cols so that we mimic the look in the homepage 3+2 icons, rather than 4+1
karelianpie
commented
Aug 4, 2023
karelianpie
commented
Aug 4, 2023
| @@ -194,6 +194,7 @@ export function useSolverPortals(): TSolverContext { | |||
| to: toAddress(to), | |||
| ...rest | |||
| }); | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
We should address these any at some point™
Majorfi
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the yETH icon to the header popover
Related Issue
Closes #312
Motivation and Context
A logo link to yETH should be available on all pages for easy navigation.
How Has This Been Tested?
Locally, screenshot below
Screenshots (if appropriate):