Add :pretty to ago #83
Conversation
|
@ramzieus Thanks for your contribution, we appreciate it! Before we can merge this pull request, we need to see all CI workflows pass without errors. We can't merge the pull request into the master branch unless all workflows are green. Try to fix them, also paying attention to code style issues. |
Those issues are related to copyright, okay I'll fix them |
lib/tago.rb
Outdated
| locals[locale] | ||
| end | ||
|
|
||
| def number_to_words(value) |
There was a problem hiding this comment.
@ramzieus we shouldn't pollute Float class with so many methods. The only method that we can add to Float is seconds.
|
@yegor256 I think it's better to use i18n gem for translation |
lib/tago.rb
Outdated
| # Author:: Ramzi Hemadou (ramzihemadou@gmail.com) | ||
| # Copyright:: Copyright (c) 2025-2026 Ramzi Hemadou | ||
| # License:: MIT | ||
| class Translate |
There was a problem hiding this comment.
@ramzieus why can't you put all this functionality into the seconds function. Making another global class is an overkill for such a small library.
2 participants
closes #56