Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk_version from default login parameters #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delthas
Copy link

@delthas delthas commented Aug 30, 2019

As of 2019-08-29 login requests that contain this field fail
with Error=UNKNOWN_ERR.

This commit removes the field and updates the tests accordingly.

See NoMore201/googleplay-api#93

As of 2019-08-29 login requests that contain this field fail
with Error=UNKNOWN_ERR.

This commit removes the field and updates the tests accordingly.

See NoMore201/googleplay-api#93
@delthas
Copy link
Author

delthas commented Aug 30, 2019

The CI build fails during setup phase, unrelated to the changes in this PR. If you'd like to fix the CI build before merging this PR, merge #41 first and rebase this PR on top of it.

@SeBsZ
Copy link

SeBsZ commented Oct 3, 2019

Please merge this and create a release, when you have time @yeriomin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants