Skip to content

Commit

Permalink
Merge pull request #353 from yetanalytics/logback_1.3.14
Browse files Browse the repository at this point in the history
Update Logback to 1.3.14
  • Loading branch information
kelvinqian00 committed Dec 7, 2023
2 parents c829be3 + d0c18b2 commit 8e7939d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deps.edn
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
danlentz/clj-uuid {:mvn/version "0.1.9"}
aero/aero {:mvn/version "1.1.6"}
selmer/selmer {:mvn/version "1.12.59"}
ch.qos.logback/logback-classic {:mvn/version "1.3.13"}
ch.qos.logback/logback-classic {:mvn/version "1.3.14"}
;; DB/JDBC deps
;; - HikariCP: Need to exclude slf4j to make logback work properly
;; - HugSql: Use custom version instead of the released version (0.5.1)
Expand Down
2 changes: 1 addition & 1 deletion doc/env_vars.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ The following environment variables are aliases for [HikariCP properties](https:

_NOTE 1:_ SQLite uses different defaults for `poolMinimumIdle` and `poolMaximumSize` than Postgres due to issues with multi-threading with those DBMSs. Setting `poolMaximumSize` to values other than `1` will potentially cause exceptions when running concurrent operations.

_NOTE 2:_ SQLite, while in in-memory mode, automatically deletes the database whenever the connection is removed, which can occur if a connection is closed and `maxLifetime` is exceeded. Thus, `maxLifetime` is set to `0`, denoting infinite connection lifetime, for convenience.
_NOTE 2:_ SQLite, while in in-memory mode, automatically deletes the database whenever the connection is removed, which can occur if a connection is closed and `poolMaxLifetime` is exceeded. Thus, `poolMaxLifetime` is set to `0`, denoting infinite connection lifetime, for convenience.

_NOTE 3:_ None of the DBMSs that SQL LRS currently supports allow for `TRANSACTION_NONE` as a `poolTransactionIsolation` value.

Expand Down

0 comments on commit 8e7939d

Please sign in to comment.