-
Notifications
You must be signed in to change notification settings - Fork 0
vision #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vision #7
Conversation
…ision # Conflicts: # src/main/java/frc/robot/RobotContainer.java
| private final DoubleSubscriber latencySubscriber; | ||
| private final DoubleSubscriber txSubscriber; | ||
| private final DoubleSubscriber tySubscriber; | ||
| private final DoubleArraySubscriber megatag1Subscriber; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need megatag 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No probably not I'll take it off and push again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no I wasn't exactly sure what it meant but now I think its pretty important. Is it causing any errors?
taran-duba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so you have the mere vision code needed to figure out where the robot is. you now need to figure out how to simulate the camera using photonvision docs and then use advantagescope to make it drive around on the field. pro tip is to make the camera a cone and then publish the cone's pose so you roughly see where it's at
taran-duba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great so far! one thing i noticed when using the camera simulator at http://localhost:1182 is that you're still on the reefscape tag map and not the crescendo one. make sure to fix that as well, wherever that may be in your code. just a few minor changes left tho!
| public static Transform3d frontCamTrans = | ||
| new Transform3d( | ||
| new Translation3d( | ||
| Units.inchesToMeters(13), | ||
| Units.inchesToMeters(0), | ||
| Units.inchesToMeters(19)), | ||
| new Rotation3d(0, Math.toRadians(-15), Math.toRadians(180))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your cone is flipped facing inside the robot. the lil point at the top of the cone should be pointing outward from the robot, not inward
|
|
||
| public static Transform3d robotToCamera0 = | ||
| new Transform3d(0.2, 0.0, 0.2, new Rotation3d(0.0, -0.4, 0.0)); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this if it's not being used
|
|
||
| intakeFeederwheel = new IntakeFeederwheelSubsystem(new IntakeFeederwheelIO() {}); | ||
|
|
||
| vision = new Vision(drive, new VisionIO() {}, new VisionIO() {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you only need 1 empty io here instead of 2 bc you only have 1 camera
taran-duba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Type of Change
Description of Changes