Skip to content

Conversation

@akashkulkarni2727
Copy link
Contributor

Type of Change

  • Bug Fix
  • New Feature
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Changes

@akashkulkarni2727 akashkulkarni2727 requested a review from a team as a code owner January 18, 2026 01:36
private final DoubleSubscriber latencySubscriber;
private final DoubleSubscriber txSubscriber;
private final DoubleSubscriber tySubscriber;
private final DoubleArraySubscriber megatag1Subscriber;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need megatag 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No probably not I'll take it off and push again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no I wasn't exactly sure what it meant but now I think its pretty important. Is it causing any errors?

Copy link
Contributor

@taran-duba taran-duba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so you have the mere vision code needed to figure out where the robot is. you now need to figure out how to simulate the camera using photonvision docs and then use advantagescope to make it drive around on the field. pro tip is to make the camera a cone and then publish the cone's pose so you roughly see where it's at

Copy link
Contributor

@taran-duba taran-duba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great so far! one thing i noticed when using the camera simulator at http://localhost:1182 is that you're still on the reefscape tag map and not the crescendo one. make sure to fix that as well, wherever that may be in your code. just a few minor changes left tho!

Comment on lines 30 to 36
public static Transform3d frontCamTrans =
new Transform3d(
new Translation3d(
Units.inchesToMeters(13),
Units.inchesToMeters(0),
Units.inchesToMeters(19)),
new Rotation3d(0, Math.toRadians(-15), Math.toRadians(180)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your cone is flipped facing inside the robot. the lil point at the top of the cone should be pointing outward from the robot, not inward


public static Transform3d robotToCamera0 =
new Transform3d(0.2, 0.0, 0.2, new Rotation3d(0.0, -0.4, 0.0));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this if it's not being used


intakeFeederwheel = new IntakeFeederwheelSubsystem(new IntakeFeederwheelIO() {});

vision = new Vision(drive, new VisionIO() {}, new VisionIO() {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only need 1 empty io here instead of 2 bc you only have 1 camera

Copy link
Contributor

@taran-duba taran-duba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@akashkulkarni2727 akashkulkarni2727 merged commit 34cfe95 into main Feb 1, 2026
1 check passed
@akashkulkarni2727 akashkulkarni2727 deleted the vision branch February 1, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants