When Taran needs a code review #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samperlmutter
requested changes
Jul 4, 2025
Member
samperlmutter
left a comment
samperlmutter
left a comment
There was a problem hiding this comment.
- where's the drivetrain?
- take a closer look at all the subsystem config files. they have some remnants of stuff that is only needed on the real beluga
- please exclude those
.datfiles that are getting generated in the.gitignore - not sure why you removed the vision simulation code
- please also add the cad assets that are needed for beluga's ascope simluation (the drive base actually should get regenerated it's very dated
src/main/java/frc/robot/subsystems/elevator/ElevatorSubsystem.java
Outdated
Show resolved
Hide resolved
samperlmutter
requested changes
Jul 18, 2025
Member
samperlmutter
left a comment
samperlmutter
left a comment
There was a problem hiding this comment.
also everything in the ctre_sim folder i think is unnecessary? what's that there for?
src/main/java/frc/robot/subsystems/vision/apriltag/AprilTagConstants.java
Outdated
Show resolved
Hide resolved
samperlmutter
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
help i desperately need a code review