-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: abstract messaging #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get everything ready for development (scripts, packages, directories, etc)
Major refactor to pull everything needed for the editor out of VE starter and into this VE lib. Adds export of Editor and the useMessage hooks. Allows usage of Editor with solely puckConfig, templateMetaData, and document as props. Corresponding VE Starter refactor PR coming shortly. Untested.
Co-authored-by: Matt Kilpatrick <mkilpatrick@yext.com>
mkilpatrick
reviewed
Aug 8, 2024
mkilpatrick
approved these changes
Aug 8, 2024
mkilpatrick
pushed a commit
to YextSolutions/pages-visual-editor-starter
that referenced
this pull request
Aug 8, 2024
This update corresponds with the removal of useMessage hook exports in VE-Lib. See this [PR](yext/visual-editor#13) for more details. --------- Co-authored-by: tsaikatie <ktsai@yext.com> Co-authored-by: ehallerYext <ehaller@yext.com> Co-authored-by: Alexis Sanehisa <106991746+asanehisa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces what we export to solely what is needed. Stops exporting TARGET_ORIGINS and TemplateMetadata. Stops exporting useMessage hooks. Adds a new hook that uses a useMessage hook but makes it really easy to just grab the document.
Also updates docs to reflect this and Editor props. New usage: