Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make quick find keyboard shortcut work #25

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

benlife5
Copy link
Contributor

Adds event listeners for cmd+k and ctrl+k. When triggered, sends a message to the parent (storm).

Adds support for the shortcut when the header or sidebars are selected. Still does not work on the puck preview iframe because we cannot add a listener to that iframe from outside the puck package.

Copy link
Contributor

@jwartofsky-yext jwartofsky-yext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkilpatrick mkilpatrick merged commit c4e1fca into main Aug 26, 2024
9 checks passed
@mkilpatrick mkilpatrick deleted the quick-find-capture branch August 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants