Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devOverride functionality #26

Merged
merged 2 commits into from
Aug 26, 2024
Merged

feat: add devOverride functionality #26

merged 2 commits into from
Aug 26, 2024

Conversation

mkilpatrick
Copy link
Collaborator

Adds functionality for devOverride coming through with templateMetadata. It can be enabled through a query param and allows dev mode to operate like normal prod mode (apart from the preview functionality). The main use case is to debug Storm/VE issues while in dev mode without needing to comment out a bunch of dev-specific code.

Also added some cleanup of getting the localStorageKey to be less redundant.

Copy link
Contributor

@asanehisa asanehisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is getLocalStorageKey used anymore? if not remove it?

@mkilpatrick
Copy link
Collaborator Author

is getLocalStorageKey used anymore? if not remove it?

It is. Editor.tsx line 62.

@mkilpatrick mkilpatrick merged commit 237db9a into main Aug 26, 2024
4 of 6 checks passed
@mkilpatrick mkilpatrick deleted the dev-override branch August 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants