Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirecting on localhost #27

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: redirecting on localhost #27

merged 1 commit into from
Aug 26, 2024

Conversation

mkilpatrick
Copy link
Collaborator

We were auto redirecting to 404 on localhost which made local development not work in Yext dev.

colton-demetriou
colton-demetriou approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@colton-demetriou colton-demetriou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you verify that localhost is actually in the ancestor?

@mkilpatrick
Copy link
Collaborator Author

did you verify that localhost is actually in the ancestor?

yes, localhost works now

@mkilpatrick mkilpatrick merged commit d770a47 into main Aug 26, 2024
9 checks passed
@mkilpatrick mkilpatrick deleted the redirect branch August 26, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantstephan briantstephan briantstephan approved these changes

@colton-demetriou colton-demetriou colton-demetriou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkilpatrick @briantstephan @colton-demetriou