Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): add renderEntityFields function #44

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

briantstephan
Copy link
Contributor

@briantstephan briantstephan commented Sep 17, 2024

This adds a renderEntityFields function which adds a selector dropdown field to a component. The selector includes any mappable entity fields, based on a provided filter.

Manually tested by calling the function from the VE starter repo and saw the selector appear in the right panel and work as expected.

Demo:
https://github.com/user-attachments/assets/d27b98a7-434c-444a-b46d-4fa61946cbae

@briantstephan briantstephan changed the title feat(dev): add renderEntityFields function feat(util): add renderEntityFields function Sep 17, 2024
Copy link
Contributor

@jwartofsky-yext jwartofsky-yext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Could you add a video?

mkilpatrick
mkilpatrick previously approved these changes Sep 18, 2024
@briantstephan briantstephan merged commit ef7cc7b into main Sep 18, 2024
9 checks passed
@briantstephan briantstephan deleted the render-entity-fields branch September 18, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants