Skip to content

Improve serialization performance for Odoo 17 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve serialization performance for Odoo 17 #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions controllers/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ def __init__(self, record, query="{*}", many=False):
self._raw_query = query
super().__init__()

@classmethod
def fields_get_keys(cls, rec):
return rec._fields

def get_parsed_restql_query(self):
parser = Parser(self._raw_query)
try:
Expand All @@ -38,11 +42,13 @@ def data(self):

@classmethod
def build_flat_field(cls, rec, field_name):
all_fields = rec.fields_get()
all_fields = cls.fields_get_keys(rec)
if field_name not in all_fields:
msg = "'%s' field is not found" % field_name
raise LookupError(msg)
field_type = rec.fields_get(field_name).get(field_name).get('type')

field = all_fields.get(field_name, None)
field_type = getattr(field, 'type', None)
if field_type in ['one2many', 'many2many']:
return {
field_name: [record.id for record in rec[field_name]]
Expand All @@ -63,16 +69,19 @@ def build_flat_field(cls, rec, field_name):
}
elif field_type == "binary" and isinstance(rec[field_name], bytes) and rec[field_name]:
return {field_name: rec[field_name].decode("utf-8")}
elif field_type == "binary" and isinstance(rec[field_name], bytes) and not rec[field_name]:
return {field_name: False}
else:
return {field_name: rec[field_name]}

@classmethod
def build_nested_field(cls, rec, field_name, nested_parsed_query):
all_fields = rec.fields_get()
all_fields = cls.fields_get_keys(rec)
if field_name not in all_fields:
msg = "'%s' field is not found" % field_name
raise LookupError(msg)
field_type = rec.fields_get(field_name).get(field_name).get('type')
field = all_fields.get(field_name, None)
field_type = getattr(field, 'type', None)
if field_type in ['one2many', 'many2many']:
return {
field_name: [
Expand Down Expand Up @@ -100,7 +109,7 @@ def serialize(cls, rec, parsed_query):
# is used to store nested fields when the exclude operator(-) is used
if parsed_query["exclude"]:
# Exclude fields from a query
all_fields = rec.fields_get()
all_fields = cls.fields_get_keys(rec)
for field in parsed_query["include"]:
if field == "*":
continue
Expand All @@ -122,7 +131,7 @@ def serialize(cls, rec, parsed_query):
# is empty which means the exclude operator(-) is not used,
# so self.parsed_restql_query["include"] contains only fields
# to include
all_fields = rec.fields_get()
all_fields = cls.fields_get_keys(rec)
if "*" in parsed_query['include']:
# Include all fields
parsed_query['include'] = filter(
Expand All @@ -143,9 +152,10 @@ def serialize(cls, rec, parsed_query):
data.update(built_nested_field)
else:
flat_field = cls.build_flat_field(rec, field)

data.update(flat_field)
else:
# The query is empty i.e query={}
# return nothing
return {}
return data
return data