Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JOIN): fix uninitialized variable bug and add code automation with .clang-format #35

Merged
merged 3 commits into from
May 31, 2024

Conversation

ygor-sena
Copy link
Owner

@ygor-sena ygor-sena commented May 31, 2024

This PR:

  1. addresses the issue of uninitialized variable flag raised by Valgrind which resulted from the case where the same client left a given channel and joined it again.
  2. add code automation with .clang-format. To automatically style your code, run at project root the following command:
    find . -iname "*.hpp" -o -iname "*.cpp" | xargs clang-format -i

@ygor-sena ygor-sena added the fix Label for solved bugs label May 31, 2024
@ygor-sena ygor-sena self-assigned this May 31, 2024
@ygor-sena ygor-sena changed the title fix(JOIN): fix uninitialized variable bug fix(JOIN): fix uninitialized variable bug and add code automation with .clang-format May 31, 2024
@ygor-sena ygor-sena added the documentation Improvements or additions to documentation label May 31, 2024
Copy link
Collaborator

@gialexan gialexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@gialexan gialexan merged commit 104729c into main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fix Label for solved bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants