Fix market hours calculation to use Eastern Time for accurate trading…#29
Open
miguelSoldado1 wants to merge 1 commit intoygwyg:mainfrom
Open
Fix market hours calculation to use Eastern Time for accurate trading…#29miguelSoldado1 wants to merge 1 commit intoygwyg:mainfrom
miguelSoldado1 wants to merge 1 commit intoygwyg:mainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix market open/close markers to use Eastern Time
Market hour markers (open at 9:30 AM, close at 4:00 PM) were using the user's local timezone instead of Eastern Time where US markets actually operate. This caused markers to appear at incorrect times for users outside of ET.
Now uses
Intl.DateTimeFormatwithAmerica/New_Yorktimezone to correctly identify market hours regardless of user location. Also handles EST/EDT transitions automatically.Note: The alpaca clock PR didn't fix the markers for me at least, added
Intl.DateTimeFormatagain but with cleaner diff