merge to main #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.9.2
Feat/deploy script
updated deployment scripts
danoctavian
reviewed
Sep 26, 2024
danoctavian
reviewed
Sep 26, 2024
Feat/use precomputed tokens
danoctavian
reviewed
Sep 28, 2024
remappings.txt
Outdated
| @@ -0,0 +1,19 @@ | |||
| @openzeppelin-upgrades-v4.9.0/=lib/eigenlayer-contracts/lib/openzeppelin-contracts-upgradeable-v4.9.0/ | |||
There was a problem hiding this comment.
this remappings file is insanely complex and contributed to all the issues plagueing the wrong import of the wrong OZ library.
I have no clue what's going on here
There was a problem hiding this comment.
Fixed by myself and pushed directly to dev
danoctavian
reviewed
Sep 28, 2024
| @@ -0,0 +1,89 @@ | |||
| # Default values | |||
There was a problem hiding this comment.
unnecessarily complex Makefile
we only need to deploy and test
Let's keep everything minimal and simple, no extra boilerplate
don't clean this one now, but going forward.
danoctavian
reviewed
Sep 28, 2024
| @@ -0,0 +1,62 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
We have no use going forward for boilerplate custom scripts converting CSV to json.
Ask the team to provide JSON, we have no reason to have all this code produced.
danoctavian
reviewed
Sep 28, 2024
script/DeployEigenAirdrop.s.sol
Outdated
| import { ProxyAdmin } from "@openzeppelin-v5.0.2/proxy/transparent/ProxyAdmin.sol"; | ||
| import { TransparentUpgradeableProxy } from | ||
| "@openzeppelin-v5.0.2/proxy/transparent/TransparentUpgradeableProxy.sol"; | ||
| import { Address } from "@openzeppelin/contracts/utils/Address.sol"; |
danoctavian
reviewed
Sep 28, 2024
script/DeployEigenAirdrop.s.sol
Outdated
| import { TransparentUpgradeableProxy } from | ||
| "@openzeppelin-v5.0.2/proxy/transparent/TransparentUpgradeableProxy.sol"; | ||
| import { Address } from "@openzeppelin/contracts/utils/Address.sol"; | ||
| import { Strings } from "@openzeppelin/contracts/utils/Strings.sol"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.