Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a message type to clear frontend messages #332

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Conversation

kahkeng
Copy link
Collaborator

@kahkeng kahkeng commented Jul 15, 2023

This will be sent by backend prior to loading messages of a session after an init.

Even though we clear this on the frontend, the backend might still have messages in the pipe being sent over that needs to be cleared.

This can be further improved if we include session id to the messages so we can do some filtering on the frontend for messages that aren't relevant to the session.

This will be sent by backend prior to loading messages of a
session after an init.

Even though we clear this on the frontend, the backend might
still have messages in the pipe being sent over that needs to be
cleared.

This can be further improved if we include session id to the
messages so we can do some filtering on the frontend for
messages that aren't relevant to the session.
@netlify
Copy link

netlify bot commented Jul 15, 2023

Deploy Preview for ironclad-parent ready!

Name Link
🔨 Latest commit 5a77cd1
🔍 Latest deploy log https://app.netlify.com/sites/ironclad-parent/deploys/64b30425a3db7d0008a8061e
😎 Deploy Preview https://deploy-preview-332--ironclad-parent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kahkeng kahkeng merged commit efb2882 into dev Jul 15, 2023
5 checks passed
@kahkeng kahkeng deleted the kahkeng/frontend_clear branch July 15, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants