fix: ens flow #402
Merged
fix: ens flow #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ironclad-parent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brucedonovan
reviewed
Aug 7, 2023
| {isRefetching ? ( | ||
| <SkeletonWrap width={100} height={10} /> | ||
| ) : ( | ||
| ensName || account.displayName |
There was a problem hiding this comment.
Suggested change
| ensName || account.displayName | |
| abbreviateHash(ensName, 8) || account.displayName |
There was a problem hiding this comment.
doesn't work as well here cuz '.eth' and if name is around tenish characters, the name shows with dots in the middle and has a wider width than without abbrv.
There was a problem hiding this comment.
cool gotcha... we might need to handle that some other way then. cos apparently a long name causes chaos.
There was a problem hiding this comment.
cool ye we can abbrv if the name length is greater than some threshold for now
Closed
brucedonovan
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't figure out wagmi hook refetching and propagating changes to the
CustomConnectButton.Ended up wrapping the wagmi action
fetchEnsNamewithreact-query. Going to do the same with the ens avatar.There is a loading sequence any time the
SingleStepContaineris rendered because we are calling the hook, which is not ideal. Figured it's ok for now.edit:
now includes refetching
ensAvatarusing our customuseEnsAvatarhook