-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ens flow #402
fix: ens flow #402
Conversation
✅ Deploy Preview for ironclad-parent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
{isRefetching ? ( | ||
<SkeletonWrap width={100} height={10} /> | ||
) : ( | ||
ensName || account.displayName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensName || account.displayName | |
abbreviateHash(ensName, 8) || account.displayName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't work as well here cuz '.eth' and if name is around tenish characters, the name shows with dots in the middle and has a wider width than without abbrv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool gotcha... we might need to handle that some other way then. cos apparently a long name causes chaos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool ye we can abbrv if the name length is greater than some threshold for now
Couldn't figure out wagmi hook refetching and propagating changes to the
CustomConnectButton
.Ended up wrapping the wagmi action
fetchEnsName
withreact-query
. Going to do the same with the ens avatar.There is a loading sequence any time the
SingleStepContainer
is rendered because we are calling the hook, which is not ideal. Figured it's ok for now.edit:
now includes refetching
ensAvatar
using our customuseEnsAvatar
hook