Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: action response and others #414

Merged
merged 23 commits into from
Aug 10, 2023
Merged

fix: action response and others #414

merged 23 commits into from
Aug 10, 2023

Conversation

marcomariscal
Copy link
Contributor

@marcomariscal marcomariscal commented Aug 9, 2023

Description

Simplifies the ActionResponse state logic/handling.

The logic flows from priority (handle highest priority states earlier when setting state), and returns the relevant state/status/label.

Was also able to add approveTx to deps by using a custom react-query hook around the wagmi prepare func for now. This mitigates stale approve info i've been running into with the yield protocol integration.

Other updates:

  • new useAllowance hook
  • useBalance hook has been updated to use react-query; old useBalance has been removed
  • improve undefined handling throughout some of the hooks
  • bigger slippage for swap because i was running into minimum out issues (likely due to fork stuff/stale fork data?); still running into issues swapping usdc to dai and vice versa

Todo

Handle tx errors where the tx gets prepped, but then leads to a failed tx.

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ironclad-parent ready!

Name Link
🔨 Latest commit b6d1eca
🔍 Latest deploy log https://app.netlify.com/sites/ironclad-parent/deploys/64d4b4dda01210000748332d
😎 Deploy Preview https://deploy-preview-414--ironclad-parent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@brucedonovan brucedonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general i'm happy with this iteration. I don't think it will be the last., but certainly better than where it was! Thanks Marco

@marcomariscal marcomariscal merged commit 93bf18b into dev Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants