ignore the year which has no running data when drawing github.svg #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yihong0618
reviewed
Sep 22, 2024
Comment on lines
91
to
95
| def count_with_data(self): | ||
| """Return number of years which has running data""" | ||
| return len(self.years_dict) | ||
|
|
There was a problem hiding this comment.
| @@ -37,6 +37,9 @@ def draw(self, dr: svgwrite.Drawing, size: XY, offset: XY): | |||
| ) | |||
| year_length = total_length_year_dict.get(year, 0) | |||
| year_length = format_float(self.poster.m2u(year_length)) | |||
|
|
|||
| if year_length == "0.0": | |||
|
Thanks |
ben-29
added a commit
to ben-29/workouts_page
that referenced
this pull request
Sep 29, 2024
* refs/heads/upstream: feat: fix nrc Changed their apis (yihong0618#718) feat: conditionally output analysis JS only in Vercel environment (yihong0618#715) ignore the year which has no running data when drawing github.svg (yihong0618#712) Fix AttributeError in Activity class (yihong0618#714) doc: fix typo close yihong0618#704 Some Front Optimization for Keep indoor data (yihong0618#709) Add new runner (yihong0618#707) feat: adding illustration for special tracks (yihong0618#705) # Conflicts: # run_page/generator/__init__.py # run_page/joyrun_sync.py
jiantian99
pushed a commit
to jiantian99/running_page
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the last github.svg like:
